Bug 157242 - Use enum class instead of string-based enums in RTC code
Summary: Use enum class instead of string-based enums in RTC code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-30 22:19 PDT by Darin Adler
Modified: 2016-05-01 09:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.76 KB, patch)
2016-04-30 22:22 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (6.76 KB, patch)
2016-04-30 22:34 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-04-30 22:19:32 PDT 
Use enum class instead of string-based enums in RTC code
Comment 1 Darin Adler 2016-04-30 22:22:09 PDT 
Created attachment 277843 [details]
Patch
Comment 2 Darin Adler 2016-04-30 22:34:27 PDT 
Created attachment 277845 [details]
Patch
Comment 3 Alex Christensen 2016-04-30 22:46:29 PDT 
Comment on attachment 277845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277845&action=review

> Source/WebCore/ChangeLog:19
> +        * Modules/mediastream/RTCConfiguration.idl: Updated the names and values of the
> +        enums to match the current RTC specification. Again, as I said, this should be

Yep, https://github.com/w3c/webrtc-pc/pull/432/files
Comment 4 WebKit Commit Bot 2016-05-01 09:36:31 PDT 
Comment on attachment 277845 [details]
Patch

Clearing flags on attachment: 277845

Committed r200304: <http://trac.webkit.org/changeset/200304>
Comment 5 WebKit Commit Bot 2016-05-01 09:36:35 PDT 
All reviewed patches have been landed.  Closing bug.