WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157237
Streamline and remove unused bindings generation code
https://bugs.webkit.org/show_bug.cgi?id=157237
Summary
Streamline and remove unused bindings generation code
Darin Adler
Reported
2016-04-30 15:26:31 PDT
Streamline and remove unused bindings generation code
Attachments
Patch
(65.31 KB, patch)
2016-04-30 15:39 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2016-04-30 15:39:50 PDT
Created
attachment 277833
[details]
Patch
Chris Dumez
Comment 2
2016-04-30 19:23:25 PDT
Comment on
attachment 277833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=277833&action=review
> Source/WebCore/Modules/notifications/NotificationCenter.idl:-39 > - int checkPermission();
We should probably drop int / unsigned int from %numericTypeHash in CodeGenerator.pm too. We should also forbid them in the IDL Parser.
Darin Adler
Comment 3
2016-04-30 20:29:48 PDT
(In reply to
comment #2
)
> We should probably drop int / unsigned int from %numericTypeHash in > CodeGenerator.pm too. We should also forbid them in the IDL Parser.
Yes, once they are all gone. There are some in internal Apple projects, which is why I didn’t do that in this patch.
WebKit Commit Bot
Comment 4
2016-04-30 21:17:23 PDT
Comment on
attachment 277833
[details]
Patch Clearing flags on attachment: 277833 Committed
r200299
: <
http://trac.webkit.org/changeset/200299
>
WebKit Commit Bot
Comment 5
2016-04-30 21:17:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug