RESOLVED FIXED157230
Some content causes deep recursion. 
https://bugs.webkit.org/show_bug.cgi?id=157230
Summary Some content causes deep recursion.
alan
Reported 2016-04-29 21:22:03 PDT
Created attachment 277795 [details] Test case See attached test case.
Attachments
Test case (649 bytes, text/html)
2016-04-29 21:22 PDT, alan 		no flags
Details
WIP patch (2.28 KB, patch)
2016-04-29 21:27 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.28 KB, patch)
2016-04-30 21:43 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.37 KB, patch)
2016-04-30 21:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-04-29 21:23:01 PDT
rdar://problem/7694756
alan
Comment 2 2016-04-29 21:27:36 PDT
Created attachment 277796 [details] WIP patch This patch limits render tree nesting. DOM can have all the nested nodes but renderer tree has only up to 512. (from 512 and up, it's like they were display: none} This (DOM vs render tree) matches FF(45.0.2) behavior.
Alexey Proskuryakov
Comment 3 2016-04-29 23:56:27 PDT
> This (DOM vs render tree) matches FF(45.0.2) behavior. But not Chrome?
alan
Comment 4 2016-04-30 06:33:31 PDT
(In reply to comment #3) > > This (DOM vs render tree) matches FF(45.0.2) behavior. > > But not Chrome? No, Chrome crashes when the stack space is exhausted.
alan
Comment 5 2016-04-30 21:43:35 PDT
Created attachment 277839 [details] Patch
Antti Koivisto
Comment 6 2016-04-30 21:45:52 PDT
Comment on attachment 277839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277839&action=review > Source/WebCore/style/StyleTreeResolver.cpp:370 > auto& element = downcast<Element>(node); > + if (it.depth() > Settings::defaultMaximumRenderTreeDepth) { An empty line after auto& element would look nicer.
alan
Comment 7 2016-04-30 21:51:46 PDT
Created attachment 277840 [details] Patch
WebKit Commit Bot
Comment 8 2016-04-30 22:41:53 PDT
Comment on attachment 277840 [details] Patch Clearing flags on attachment: 277840 Committed r200301: <http://trac.webkit.org/changeset/200301>
WebKit Commit Bot
Comment 9 2016-04-30 22:41:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.