RESOLVED WONTFIX 157227
Add [NewObject] IDL extended attribute to Text.splitText() 
https://bugs.webkit.org/show_bug.cgi?id=157227
Summary Add [NewObject] IDL extended attribute to Text.splitText()
Chris Dumez
Reported 2016-04-29 20:30:50 PDT
Add [NewObject] IDL extended attribute to Text.splitText() as per: https://dom.spec.whatwg.org/#text Our implementation already returns a new object every time but adding the attribute in the IDL lets us generate slightly more efficient code as we do not need to check if a wrapper already exists for the returned object.
Attachments
Patch (1.65 KB, patch)
2016-04-29 20:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-04-29 20:34:34 PDT
Created attachment 277788 [details] Patch
Chris Dumez
Comment 2 2016-04-29 21:06:54 PDT
Looks like there is a failure in debug. I'll investigate.
Chris Dumez
Comment 3 2016-04-29 21:12:53 PDT
Darn, this does not work because Text.splitText() fires synchronous DOM Mutation events and those may access the new Text node before it is even returned :/ Covered by fast/dom/Range/split-text-in-range.html
Ryosuke Niwa
Comment 4 2016-04-29 21:17:06 PDT
(In reply to comment #3) > Darn, this does not work because Text.splitText() fires synchronous DOM > Mutation events and those may access the new Text node before it is even > returned :/ > > Covered by fast/dom/Range/split-text-in-range.html Oh no :(
Darin Adler
Comment 5 2016-04-29 21:22:39 PDT
mutation events are the worst
Note You need to log in before you can comment on or make changes to this bug.