Bug 157219 – AX: @aria-label attribute should work on <label> element

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

In case:
<label for="txtBox1" aria-label="Enter date in format MM/DD/YY">Date:</label>
<input id="txtBox1" />

I would expect the value specified in the aria-label attribute to supersede the actual value of the label. I.e. I would expect VoiceOver to announce "Enter date in format MM/DD/YY". Instead the base value is announced ("Date").

<rdar://problem/15199588>

[Nan Wang]

Created attachment 277769 [details]
initial patch

[chris fleizach]

Comment on attachment 277769 [details]
initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277769&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1269
> +            // If there's aria-label on the label, we should use it instead.

this comment seems unnecessary, since its self evident from the code

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1270
> +            const AtomicString& labelStr = labelObject->getAttribute(aria_labelAttr);

const AtomicString& ariaLabel

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1075
> +    // otherwise its inner text will be announced by screenreader.

announced by "a" screenrea

[Nan Wang]

Created attachment 277799 [details]
patch

applied review comments

[WebKit Commit Bot]

Comment on attachment 277799 [details]
patch

Clearing flags on attachment: 277799

Committed r200290: <http://trac.webkit.org/changeset/200290>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.