Bug 157217 - [JSC][ARMv7S] Arithmetic module results change when tiering up to DFG
Summary: [JSC][ARMv7S] Arithmetic module results change when tiering up to DFG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 16:58 PDT by Benjamin Poulain
Modified: 2016-04-29 18:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.04 KB, patch)
2016-04-29 17:07 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-04-29 16:58:37 PDT
[JSC][ARMv7S] Arithmetic module results change when tiering up to DFG
Comment 1 Benjamin Poulain 2016-04-29 17:07:34 PDT
Created attachment 277761 [details]
Patch
Comment 2 Mark Lam 2016-04-29 18:04:52 PDT
Comment on attachment 277761 [details]
Patch

r=me.  I see that the op_mod.js test will test combinations of positive and negative numbers of interesting sizes.  I trust that if this patch passes the op_mod.js test on ARMv7s, then your decision of when to use the integer math and when to defer to fmod is correct.
Comment 3 WebKit Commit Bot 2016-04-29 18:50:11 PDT
Comment on attachment 277761 [details]
Patch

Clearing flags on attachment: 277761

Committed r200277: <http://trac.webkit.org/changeset/200277>
Comment 4 WebKit Commit Bot 2016-04-29 18:50:16 PDT
All reviewed patches have been landed.  Closing bug.