RESOLVED FIXED 157212
Web Inspector: Scrolling in Timelines causes flashing of the DataGrid 
https://bugs.webkit.org/show_bug.cgi?id=157212
Summary Web Inspector: Scrolling in Timelines causes flashing of the DataGrid
Timothy Hatcher
Reported 2016-04-29 16:10:56 PDT
Scrolling a DataGrid causes flashing as it updates. It should not flash. <rdar://problem/25994717>
Attachments
Patch (3.72 KB, patch)
2016-04-29 16:16 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-29 16:11:58 PDT
<rdar://problem/26016796>
Timothy Hatcher
Comment 2 2016-04-29 16:16:28 PDT
Created attachment 277750 [details] Patch
Joseph Pecoraro
Comment 3 2016-04-29 16:20:42 PDT
Comment on attachment 277750 [details] Patch r=me
Blaze Burg
Comment 4 2016-04-29 16:50:05 PDT
Comment on attachment 277750 [details] Patch r=me too It's better. I still think we could do more: - predict scroll speed and pre-render expected rows - adjust the buffer amount depending on the viewport size
Nikita Vasilyev
Comment 5 2016-04-29 16:57:32 PDT
(In reply to comment #4) > Comment on attachment 277750 [details] > Patch > > r=me too > > It's better. I still think we could do more: > - predict scroll speed and pre-render expected rows This is how CodeMirror does it: http://marijnhaverbeke.nl/blog/a-pathological-scrolling-model.html https://github.com/codemirror/CodeMirror/blob/6164344b260b9af76826fd71b6923684a156984d/lib/codemirror.js#L3970 I posted it on #webkit-inspector last week, but I'm not sure it got noticed.
WebKit Commit Bot
Comment 6 2016-04-29 17:09:45 PDT
Comment on attachment 277750 [details] Patch Clearing flags on attachment: 277750 Committed r200270: <http://trac.webkit.org/changeset/200270>
WebKit Commit Bot
Comment 7 2016-04-29 17:09:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.