Bug 157212 - Web Inspector: Scrolling in Timelines causes flashing of the DataGrid
Summary: Web Inspector: Scrolling in Timelines causes flashing of the DataGrid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-29 16:10 PDT by Timothy Hatcher
Modified: 2016-04-29 17:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2016-04-29 16:16 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-04-29 16:10:56 PDT 
Scrolling a DataGrid causes flashing as it updates. It should not flash.

<rdar://problem/25994717>
Comment 1 Radar WebKit Bug Importer 2016-04-29 16:11:58 PDT 
<rdar://problem/26016796>
Comment 2 Timothy Hatcher 2016-04-29 16:16:28 PDT 
Created attachment 277750 [details]
Patch
Comment 3 Joseph Pecoraro 2016-04-29 16:20:42 PDT 
Comment on attachment 277750 [details]
Patch

r=me
Comment 4 BJ Burg 2016-04-29 16:50:05 PDT 
Comment on attachment 277750 [details]
Patch

r=me too

It's better. I still think we could do more:
 - predict scroll speed and pre-render expected rows
 - adjust the buffer amount depending on the viewport size
Comment 5 Nikita Vasilyev 2016-04-29 16:57:32 PDT 
(In reply to comment #4)
> Comment on attachment 277750 [details]
> Patch
> 
> r=me too
> 
> It's better. I still think we could do more:
>  - predict scroll speed and pre-render expected rows

This is how CodeMirror does it:
http://marijnhaverbeke.nl/blog/a-pathological-scrolling-model.html
https://github.com/codemirror/CodeMirror/blob/6164344b260b9af76826fd71b6923684a156984d/lib/codemirror.js#L3970

I posted it on #webkit-inspector last week, but I'm not sure it got noticed.
Comment 6 WebKit Commit Bot 2016-04-29 17:09:45 PDT 
Comment on attachment 277750 [details]
Patch

Clearing flags on attachment: 277750

Committed r200270: <http://trac.webkit.org/changeset/200270>
Comment 7 WebKit Commit Bot 2016-04-29 17:09:49 PDT 
All reviewed patches have been landed.  Closing bug.