Bug 157211 - Node.nodeName should not be nullable
Summary: Node.nodeName should not be nullable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 16:03 PDT by Chris Dumez
Modified: 2016-04-29 17:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2016-04-29 16:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-29 16:03:24 PDT 
Node.nodeName should not be nullable as per the specification:
https://dom.spec.whatwg.org/#interface-node

Our implementation never returns null anyway. However, having it as nullable in the IDL means we use jsStringOrNull() instead of jsStringWithCache(), thus doing an unnecessary null check.
Comment 1 Chris Dumez 2016-04-29 16:08:28 PDT 
Created attachment 277748 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-29 17:12:04 PDT 
Comment on attachment 277748 [details]
Patch

Clearing flags on attachment: 277748

Committed r200271: <http://trac.webkit.org/changeset/200271>
Comment 3 WebKit Commit Bot 2016-04-29 17:12:10 PDT 
All reviewed patches have been landed.  Closing bug.