Add null checks when comparing SSL certificates
Created attachment 277736 [details] Patch
Is this rdar://problem/21723172?
(In reply to comment #2) > Is this rdar://problem/21723172? No. This has never shipped.
Hmm. But it still seems like the same logic for why we shouldn't add a null check would apply. What's the difference here?
Created attachment 277923 [details] Patch
Comment on attachment 277923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277923&action=review I do not have a particularly strong opinion on whether we should paper over the problem, or crash. This is clearly an improvement. > Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:343 > + RELEASE_ASSERT(cert1 && cert2) Please add separate assertions for each, to make it easier to see what failed.
http://trac.webkit.org/changeset/200335