RESOLVED FIXED 157206
Add null checks when comparing SSL certificates 
https://bugs.webkit.org/show_bug.cgi?id=157206
Summary Add null checks when comparing SSL certificates
Alex Christensen
Reported 2016-04-29 15:17:16 PDT
Add null checks when comparing SSL certificates
Attachments
Patch (1.60 KB, patch)
2016-04-29 15:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.64 KB, patch)
2016-05-02 12:42 PDT, Alex Christensen 		ap: review+
ap: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-04-29 15:18:28 PDT
Created attachment 277736 [details] Patch
Alexey Proskuryakov
Comment 2 2016-04-29 15:37:39 PDT
Is this rdar://problem/21723172?
Alex Christensen
Comment 3 2016-04-29 17:03:12 PDT
(In reply to comment #2) > Is this rdar://problem/21723172? No. This has never shipped.
Alexey Proskuryakov
Comment 4 2016-04-29 17:07:23 PDT
Hmm. But it still seems like the same logic for why we shouldn't add a null check would apply. What's the difference here?
Alex Christensen
Comment 5 2016-05-02 12:42:19 PDT
Created attachment 277923 [details] Patch
Alexey Proskuryakov
Comment 6 2016-05-02 13:13:17 PDT
Comment on attachment 277923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277923&action=review I do not have a particularly strong opinion on whether we should paper over the problem, or crash. This is clearly an improvement. > Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:343 > + RELEASE_ASSERT(cert1 && cert2) Please add separate assertions for each, to make it easier to see what failed.
Alex Christensen
Comment 7 2016-05-02 13:25:47 PDT
http://trac.webkit.org/changeset/200335
Note You need to log in before you can comment on or make changes to this bug.