Bug 157204 - Drop useless check in SpeculativeLoadManager::registerLoad()
Summary: Drop useless check in SpeculativeLoadManager::registerLoad()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 14:54 PDT by Chris Dumez
Modified: 2016-04-29 20:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2016-04-29 15:03 PDT, Chris Dumez 		koivisto: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-29 14:54:55 PDT 
Drop useless check in SpeculativeLoadManager::registerLoad()
Comment 1 Chris Dumez 2016-04-29 15:03:15 PDT 
Created attachment 277734 [details]
Patch
Comment 2 Antti Koivisto 2016-04-29 20:29:40 PDT 
Comment on attachment 277734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277734&action=review

> Source/WebKit2/ChangeLog:14
> +2016-04-29  Chris Dumez  <cdumez@apple.com>
> +
> +        Drop useless check in SpeculativeLoadManager::registerLoad()
> +        https://bugs.webkit.org/show_bug.cgi?id=157204
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Drop useless check in SpeculativeLoadManager::registerLoad(). There is
> +        no way to end up this code path with a non-HTTP family request.
> +
> +        * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
> +        (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
> +
> +2016-04-29  Chris Dumez  <cdumez@apple.com>

ChangeLog repeats
Comment 3 Chris Dumez 2016-04-29 20:36:18 PDT 
Committed r200281: <http://trac.webkit.org/changeset/200281>