Bug 157192 - [Win] Enable IndexedDB.
Summary: [Win] Enable IndexedDB.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 11:15 PDT by peavo
Modified: 2016-05-02 11:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.30 KB, patch)
2016-04-29 11:31 PDT, peavo
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-04-29 11:15:06 PDT
It would be nice to have this feature enabled on Windows.
Comment 1 peavo 2016-04-29 11:31:50 PDT
Created attachment 277723 [details]
Patch
Comment 2 peavo 2016-04-29 11:33:53 PDT
This patch needs VS2015 Update 2 to compile.
Comment 3 Brent Fulgham 2016-04-29 13:15:58 PDT
Comment on attachment 277723 [details]
Patch

Oh, nice! r=me, but please hold off landing until I get the bots updated. I'll do that today.
Comment 4 peavo 2016-04-29 13:22:47 PDT
(In reply to comment #3)
> Comment on attachment 277723 [details]
> Patch
> 
> Oh, nice! r=me, but please hold off landing until I get the bots updated.
> I'll do that today.

Thanks for reviewing!
Comment 5 Alex Christensen 2016-04-29 13:37:27 PDT
(In reply to comment #2)
> This patch needs VS2015 Update 2 to compile.
What exactly needs update 2?  What happens if you compile without it?
Comment 6 peavo 2016-04-29 13:58:33 PDT
(In reply to comment #5)
> (In reply to comment #2)
> > This patch needs VS2015 Update 2 to compile.
> What exactly needs update 2?  What happens if you compile without it?

I get a compile error in the method UniqueIDBDatabase::activateTransactionInBackingStore.

error C2668: 'WebCore::IDBServer::UniqueIDBDatabase::storeCallback': ambiguous call to overloaded function

void UniqueIDBDatabase::activateTransactionInBackingStore(UniqueIDBDatabaseTransaction& transaction)
{
    LOG(IndexedDB, "(main) UniqueIDBDatabase::activateTransactionInBackingStore");

    RefPtr<UniqueIDBDatabase> self(this);
    RefPtr<UniqueIDBDatabaseTransaction> refTransaction(&transaction);

    auto callback = [this, self, refTransaction](const IDBError& error) {
        refTransaction->didActivateInBackingStore(error);
    };

    uint64_t callbackID = storeCallback(callback);
    m_server.postDatabaseTask(createCrossThreadTask(*this, &UniqueIDBDatabase::performActivateTransactionInBackingStore, callbackID, transaction.info()));
}
Comment 7 peavo 2016-05-02 11:40:00 PDT
Committed r200328: <http://trac.webkit.org/changeset/200328>