Bug 157192 – [Win] Enable IndexedDB.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

It would be nice to have this feature enabled on Windows.

Created attachment 277723 [details]
Patch

This patch needs VS2015 Update 2 to compile.

[Brent Fulgham]

Comment on attachment 277723 [details]
Patch

Oh, nice! r=me, but please hold off landing until I get the bots updated. I'll do that today.

(In reply to comment #3)
> Comment on attachment 277723 [details]
> Patch
> 
> Oh, nice! r=me, but please hold off landing until I get the bots updated.
> I'll do that today.

Thanks for reviewing!

[Alex Christensen]

(In reply to comment #2)
> This patch needs VS2015 Update 2 to compile.
What exactly needs update 2?  What happens if you compile without it?

(In reply to comment #5)
> (In reply to comment #2)
> > This patch needs VS2015 Update 2 to compile.
> What exactly needs update 2?  What happens if you compile without it?

I get a compile error in the method UniqueIDBDatabase::activateTransactionInBackingStore.

error C2668: 'WebCore::IDBServer::UniqueIDBDatabase::storeCallback': ambiguous call to overloaded function

void UniqueIDBDatabase::activateTransactionInBackingStore(UniqueIDBDatabaseTransaction& transaction)
{
    LOG(IndexedDB, "(main) UniqueIDBDatabase::activateTransactionInBackingStore");

    RefPtr<UniqueIDBDatabase> self(this);
    RefPtr<UniqueIDBDatabaseTransaction> refTransaction(&transaction);

    auto callback = [this, self, refTransaction](const IDBError& error) {
        refTransaction->didActivateInBackingStore(error);
    };

    uint64_t callbackID = storeCallback(callback);
    m_server.postDatabaseTask(createCrossThreadTask(*this, &UniqueIDBDatabase::performActivateTransactionInBackingStore, callbackID, transaction.info()));
}

Committed r200328: <http://trac.webkit.org/changeset/200328>