Bug 157191 - Allow contributors to edit the wiki
Summary: Allow contributors to edit the wiki
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
Keywords: InRadar
Depends on:
Reported: 2016-04-29 11:10 PDT by Carlos Alberto Lopez Perez
Modified: 2018-04-25 18:42 PDT (History)
5 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2016-04-29 11:10:31 PDT
It would be nice if we allow contributors (as listed in the "Contributors" field of contributors.json) to edit the wiki at https://trac.webkit.org

This may be useful for example for WebKitGTK+ gardeners (some of them still not committers) can edit the wiki at https://trac.webkit.org/wiki/WebKitGTK/Gardening/Calendar

Since in the file contributors.json are also listed the committeers and reviewers, a possible implementation idea is to give wiki edit permissions to anyone listed on that file. That way there is only one source of information to check for this permission.
Comment 1 Lucas Forschler 2016-04-29 11:27:53 PDT
The current trac authenticate list is taken from the svn.webkit.org authz.conf file.
It should be fairly simple to supplement that list with the contributors list from source.
Comment 2 Radar WebKit Bug Importer 2016-04-29 11:28:35 PDT
Comment 3 Lucas Forschler 2016-05-16 19:50:19 PDT
I've manually added all of the "Contributors" in contributors.json.

We should consider adding a post-commit hook to svn.webkit.org to do this anytime the contributors.json file is updated. However, the hook will need a fair bit of testing. Also, we'll likely need to run an operation to remove permissions before adding them back in, such that we can cover cases where users are added or removed.
Comment 4 Lucas Forschler 2016-05-16 19:51:27 PDT
And by manually, I mean I've wrote a script which does this work for us... (however it is run manually, not via hook or other automation)
Comment 5 Lucas Forschler 2017-09-06 15:19:32 PDT
I've updated our tools to take all emails from contributors.json and give them wiki permissions.
Comment 6 Carlos Eduardo Ramalho 2018-04-25 18:42:45 PDT
Hi! I recently added myself as contributor on bug 184082 but I haven't got permission to edit the wiki yet.

Has the permissions script been updated and stopped granting permissions to contributors listed in contributors.json?