Bug 157177 - Limit ResourceTiming to WEB_TIMING enabled builds
Summary: Limit ResourceTiming to WEB_TIMING enabled builds
Status: RESOLVED DUPLICATE of bug 157133
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-29 05:44 PDT by Yoav Weiss
Modified: 2016-04-29 12:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2016-04-29 05:47 PDT, Yoav Weiss 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2016-04-29 05:44:31 PDT 
Limit ResourceTiming to WEB_TIMING enabled builds
Comment 1 Yoav Weiss 2016-04-29 05:47:50 PDT 
Created attachment 277694 [details]
Patch
Comment 2 Yoav Weiss 2016-04-29 05:50:44 PDT 
When looking into why https://bugs.webkit.org/show_bug.cgi?id=157133 broke the Mac cmake build, I saw that the build breaks when WEB_TIMING is not enabled (which is the case for the Mac cmake build).

This corrects such builds. As a next step, I also intend to turn on WEB_TIMING on the Mac cmake build by default.
Comment 3 Alex Christensen 2016-04-29 10:04:06 PDT 
Comment on attachment 277694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277694&action=review

> Source/WebCore/page/PerformanceResourceTiming.h:88
> +#endif // !ENABLE(WEB_TIMING)

no !
Comment 4 Yoav Weiss 2016-04-29 12:21:48 PDT 
Since https://bugs.webkit.org/show_bug.cgi?id=157133 got reverted, this patch can no longer be applied. I'll merge it into the one in 157133

*** This bug has been marked as a duplicate of bug 157133 ***