Bug 157159 - RTL <select> popup menu is in the wrong location
Summary: RTL <select> popup menu is in the wrong location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 157183
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-28 17:27 PDT by Dean Jackson
Modified: 2016-04-29 17:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.56 KB, patch)
2016-04-28 17:31 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-04-28 17:27:24 PDT 
RTL <select> popup menu is in the wrong location
Comment 1 Dean Jackson 2016-04-28 17:27:48 PDT 
<rdar://problem/25894451>
Comment 2 Dean Jackson 2016-04-28 17:31:08 PDT 
Created attachment 277667 [details]
Patch
Comment 3 Dean Jackson 2016-04-28 17:42:03 PDT 
Committed r200217: <http://trac.webkit.org/changeset/200217>
Comment 4 Csaba Osztrogonác 2016-04-28 23:17:41 PDT 
(In reply to comment #3)
> Committed r200217: <http://trac.webkit.org/changeset/200217>

It broke the Apple Mac Yosemite build, see build.webkit.org for details.
Comment 5 WebKit Commit Bot 2016-04-29 09:28:54 PDT 
Re-opened since this is blocked by bug 157183
Comment 6 Ryan Haddad 2016-04-29 10:13:01 PDT 
Link to failing Yosemite build:
<https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20%28Build%29/builds/14561>

/Volumes/Data/slave/yosemite-debug/build/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm:158:11: error: 'NSMenu' may not respond to 'setUserInterfaceLayoutDirection:' [-Werror]
Comment 7 Dean Jackson 2016-04-29 17:02:28 PDT 
Back in r200268