Bug 157156 - Remove unused bool parameter in CodeCache::getGlobalCodeBlock
Summary: Remove unused bool parameter in CodeCache::getGlobalCodeBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 16:46 PDT by Joseph Pecoraro
Modified: 2016-04-28 17:53 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (10.52 KB, patch)
2016-04-28 16:56 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-28 16:46:26 PDT
* SUMMARY
Remove unused bool parameter in CodeCache::getGlobalCodeBlock.

Seems this was intended to be "isArrowFunctionContext" for CodeCache::getEvalCodeBlock, but CodeCache::getGlobalCodeBlock just checks the executable->isArrowFunctionContext, so the boolean parameter was never named or used since it was added. Just remove it.
Comment 1 Joseph Pecoraro 2016-04-28 16:56:24 PDT
Created attachment 277665 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-04-28 17:02:31 PDT
Comment on attachment 277665 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2016-04-28 17:53:01 PDT
Comment on attachment 277665 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 277665

Committed r200218: <http://trac.webkit.org/changeset/200218>
Comment 4 WebKit Commit Bot 2016-04-28 17:53:04 PDT
All reviewed patches have been landed.  Closing bug.