Bug 157147 - [Mac] AirPlay fails if target is set before AVPlayer has been created
Summary: [Mac] AirPlay fails if target is set before AVPlayer has been created
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on: 157251
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-28 11:49 PDT by Eric Carlson
Modified: 2016-05-02 18:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch for the bots. (17.83 KB, patch)
2016-04-28 12:17 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (17.83 KB, patch)
2016-04-28 13:07 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Proposed patch. (1.68 KB, patch)
2016-05-02 18:00 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-04-28 11:49:02 PDT 
AirPlay never starts if the playback target is set before the AVPlayer has been created.
Comment 1 Eric Carlson 2016-04-28 11:49:59 PDT 
<rdar://problem/24197592>
Comment 2 Eric Carlson 2016-04-28 12:17:39 PDT 
Created attachment 277639 [details]
Patch for the bots.
Comment 3 WebKit Commit Bot 2016-04-28 12:18:50 PDT 
Attachment 277639 [details] did not pass style-queue:


WARNING: Not running on native Windows.
ERROR: Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:48:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2016-04-28 13:07:09 PDT 
Created attachment 277642 [details]
Updated patch
Comment 5 WebKit Commit Bot 2016-04-29 14:28:30 PDT 
Comment on attachment 277642 [details]
Updated patch

Clearing flags on attachment: 277642

Committed r200264: <http://trac.webkit.org/changeset/200264>
Comment 6 WebKit Commit Bot 2016-04-29 14:28:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Carlson 2016-04-29 15:40:37 PDT 
Plus https://trac.webkit.org/r200266 to make the test less flaky.
Comment 8 Ryan Haddad 2016-04-29 17:09:04 PDT 
LayoutTest media/media-source/media-source-stalled-holds-sleep-assertion.html has been timing out on Mac since r200264 landed.

<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-source%2Fmedia-source-stalled-holds-sleep-assertion.html>
Comment 9 WebKit Commit Bot 2016-05-01 17:26:33 PDT 
Re-opened since this is blocked by bug 157251
Comment 10 Eric Carlson 2016-05-02 18:00:25 PDT 
Created attachment 277953 [details]
Proposed patch.
Comment 11 Dean Jackson 2016-05-02 18:03:12 PDT 
Comment on attachment 277953 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=277953&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1040
> +        // Clear m_shouldPlayToPlaybackTarget so doesn't return without doing anything.

Typo: missing "it"
Comment 12 WebKit Commit Bot 2016-05-02 18:39:16 PDT 
Comment on attachment 277953 [details]
Proposed patch.

Clearing flags on attachment: 277953

Committed r200354: <http://trac.webkit.org/changeset/200354>
Comment 13 WebKit Commit Bot 2016-05-02 18:39:21 PDT 
All reviewed patches have been landed.  Closing bug.