Bug 157143 - DebuggerScope::className() should not assert scope->isValid().
Summary: DebuggerScope::className() should not assert scope->isValid().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-28 11:05 PDT by Mark Lam
Modified: 2016-04-28 11:34 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (1.86 KB, patch)
2016-04-28 11:12 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-04-28 11:05:08 PDT 
DebuggerScope::className() should not assert scope->isValid() because the TypeProfiler logs objects it encounters, and may indirectly call JSObject::calculatedClassName() on those objects later, thereby calling DebuggerScope::className() on an invalidated DebuggerScope.  The existing handling in DebuggerScope::className() for an invalidated scope (that returns a null string) is sufficient.
Comment 1 Mark Lam 2016-04-28 11:10:32 PDT 
<rdar://problem/20790971>
Comment 2 Mark Lam 2016-04-28 11:12:26 PDT 
Created attachment 277634 [details]
proposed patch.
Comment 3 Keith Miller 2016-04-28 11:15:40 PDT 
Comment on attachment 277634 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2016-04-28 11:19:04 PDT 
Thanks for the review.  Landed in r200200: <http://trac.webkit.org/r200200>.
Comment 5 Mark Lam 2016-04-28 11:30:24 PDT 
Correction: this bug is not <rdar://problem/20790971>.  There was a mis-aggregation.
Comment 6 Radar WebKit Bug Importer 2016-04-28 11:33:42 PDT 
<rdar://problem/25985293>
Comment 7 Radar WebKit Bug Importer 2016-04-28 11:34:40 PDT 
<rdar://problem/25985379>