Bug 157140 - REGRESSION(r200171?, r200164?) animations/animation-events-not-cancelable.html is flaky on Mac/iOS
Summary: REGRESSION(r200171?, r200164?) animations/animation-events-not-cancelable.htm...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 10:17 PDT by Ryan Haddad
Modified: 2016-04-29 16:48 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-04-28 10:17:43 PDT
LayoutTest animations/animation-events-not-cancelable.html has become flaky on Mac and iOS as of r200171. Since it is a flaky failure, I am not sure if that change is directly related.

Example failure:
<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Debug%20WK2%20(Tests)/r200191%20(1438)/results.html>

Flakiness dashboard:
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fanimation-events-not-cancelable.html>

--- /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/animations/animation-events-not-cancelable-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/animations/animation-events-not-cancelable-actual.txt
@@ -5,8 +5,6 @@
 
 animationstart:
 PASS event.cancelable is false
-animationiteration:
-PASS event.cancelable is false
 animationend:
 PASS event.cancelable is false
 PASS successfullyParsed is true
Comment 1 Simon Fraser (smfr) 2016-04-28 15:55:32 PDT
Attempted improvement in https://trac.webkit.org/r200213
Comment 2 Alexey Proskuryakov 2016-04-29 16:34:27 PDT
This made it much, much better. But I still found one failure on iOS (WK1 production, same diff).
Comment 3 Simon Fraser (smfr) 2016-04-29 16:40:06 PDT
Yeah. On a loaded bot, the animation won't get serviced frequently enough to fire the iteration event. I don't know how to fix this.
Comment 4 Alexey Proskuryakov 2016-04-29 16:48:09 PDT
This particular test seems like it would be nearly as good if it didn't log anything on success. There is the risk it will somehow never fire the animationiteration at some point in the future and thus stop testing it, but that seems unlikely.

Also, perhaps it's a bug that we allow skipping an iteration?