Bug 157139 - [JSC] implement spec changes for String#padStart and String#padEnd
Summary: [JSC] implement spec changes for String#padStart and String#padEnd
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 09:06 PDT by Caitlin Potter (:caitp)
Modified: 2016-04-28 10:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2016-04-28 09:08 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2016-04-28 09:12 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caitlin Potter (:caitp) 2016-04-28 09:06:29 PDT 
[JSC] implement spec changes for String#padStart and String#padEnd
Comment 1 Caitlin Potter (:caitp) 2016-04-28 09:08:00 PDT 
Created attachment 277625 [details]
Patch

A followup to move this implementation to self-hosted JS will follow
Comment 2 WebKit Commit Bot 2016-04-28 09:10:21 PDT 
Attachment 277625 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Caitlin Potter (:caitp) 2016-04-28 09:12:53 PDT 
Created attachment 277626 [details]
Patch

...and make check-webkit-style happy
Comment 4 Keith Miller 2016-04-28 09:45:56 PDT 
Comment on attachment 277626 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2016-04-28 10:04:49 PDT 
Comment on attachment 277626 [details]
Patch

Clearing flags on attachment: 277626

Committed r200194: <http://trac.webkit.org/changeset/200194>
Comment 6 WebKit Commit Bot 2016-04-28 10:04:54 PDT 
All reviewed patches have been landed.  Closing bug.