WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157137
[css-grid] Unprefix CSS Grid Layout properties
https://bugs.webkit.org/show_bug.cgi?id=157137
Summary
[css-grid] Unprefix CSS Grid Layout properties
Manuel Rego Casasnovas
Reported
2016-04-28 07:29:41 PDT
After adding the runtime feature in
bug #157134
we should be able to unprefix the CSS Grid Layout properties. More info at:
https://lists.webkit.org/pipermail/webkit-dev/2016-April/028192.html
Attachments
Patch
(1.98 MB, patch)
2016-04-29 00:27 PDT
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1
2016-04-29 00:27:22 PDT
Created
attachment 277680
[details]
Patch
Manuel Rego Casasnovas
Comment 2
2016-05-04 08:16:44 PDT
It seems that after the discussion on the mailing list everybody is fine with unprefixing grid layout. So I'm pinging reviewers, please could you take a look? Otherwise I'll need to upload a new version as soon as some new grid layout patches land. Thanks!
Simon Fraser (smfr)
Comment 3
2016-05-05 12:44:27 PDT
Comment on
attachment 277680
[details]
Patch r=me if you're ok removing support for the prefixed version.
Sergio Villar Senin
Comment 4
2016-05-06 00:24:49 PDT
(In reply to
comment #3
)
> Comment on
attachment 277680
[details]
> Patch > > r=me if you're ok removing support for the prefixed version.
r=me too I think we're safe removing it. We haven't shipped the feature, it has only been enabled in the last Safari technology preview and both Firefox and Chrome are using unprefixed versions. Last but not least, as Manuel says, almost all the examples out there are also using unprefixed versions.
WebKit Commit Bot
Comment 5
2016-05-06 01:16:59 PDT
Comment on
attachment 277680
[details]
Patch Clearing flags on attachment: 277680 Committed
r200510
: <
http://trac.webkit.org/changeset/200510
>
WebKit Commit Bot
Comment 6
2016-05-06 01:17:04 PDT
All reviewed patches have been landed. Closing bug.
yisibl
Comment 7
2016-05-24 00:38:08 PDT
missing -webkit-min-content and -webkit-max-content
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug