Bug 157129 - [css-grid] Fix typo in CSS class for layout tests
Summary: [css-grid] Fix typo in CSS class for layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-04-28 04:43 PDT by Manuel Rego Casasnovas
Modified: 2016-04-28 07:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2016-04-28 04:44 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-04-28 04:43:55 PDT 
[css-grid] Fix typo in CSS class for layout tests
Comment 1 Manuel Rego Casasnovas 2016-04-28 04:44:31 PDT 
Created attachment 277610 [details]
Patch
Comment 2 Sergio Villar Senin 2016-04-28 05:07:46 PDT 
Comment on attachment 277610 [details]
Patch

What about removing it?
Comment 3 Manuel Rego Casasnovas 2016-04-28 06:13:31 PDT 
Thanks for the review.

(In reply to comment #2)
> Comment on attachment 277610 [details]
> Patch
> 
> What about removing it?

The class is called "secondRowFourthColumn", so I prefer to keep it.
So if it's used in a future test (with less items) it'd work properly.

Other option would be to change what's used in those tests for something like "autoRowFourthColumn", but I think it doesn't worth it.
Comment 4 WebKit Commit Bot 2016-04-28 07:01:34 PDT 
Comment on attachment 277610 [details]
Patch

Clearing flags on attachment: 277610

Committed r200189: <http://trac.webkit.org/changeset/200189>
Comment 5 WebKit Commit Bot 2016-04-28 07:01:38 PDT 
All reviewed patches have been landed.  Closing bug.