Bug 157124 - [ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard
Summary: [ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof`...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 157265
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-28 01:19 PDT by Yusuke Suzuki
Modified: 2016-05-02 03:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2016-04-28 01:22 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-04-28 01:19:57 PDT 
[ES6] RegExp.prototype.@@replace should use @isObject instead of `instanceof` for object guard
Comment 1 Yusuke Suzuki 2016-04-28 01:22:46 PDT 
Created attachment 277606 [details]
Patch
Comment 2 Keith Miller 2016-04-28 06:34:50 PDT 
Comment on attachment 277606 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2016-04-29 03:46:23 PDT 
Comment on attachment 277606 [details]
Patch

Thank you for your review!
Comment 4 WebKit Commit Bot 2016-04-29 04:35:57 PDT 
Comment on attachment 277606 [details]
Patch

Clearing flags on attachment: 277606

Committed r200239: <http://trac.webkit.org/changeset/200239>
Comment 5 WebKit Commit Bot 2016-04-29 04:36:02 PDT 
All reviewed patches have been landed.  Closing bug.