RESOLVED FIXED 157120
The GetterSetter structure needs a globalObject. 
https://bugs.webkit.org/show_bug.cgi?id=157120
Summary The GetterSetter structure needs a globalObject.
Mark Lam
Reported 2016-04-27 22:44:38 PDT
In r199170: <http://trac.webkit.org/changeset/199170>, GetterSetter was promoted from a JSCell to a JSObject. JSObject methods expect their structure to have a globalObject. For example, see JSObject::calculatedClassName(). GetterSetter was previously using a singleton getterSetterStructure owned by the VM. That singleton getterSetterStructure is not associated with any globalObjects. As a result, JSObject::calculatedClassName() will run into a null globalObject when it is called on a GetterSetter object. This patch removes the VM singleton getterSetterStructure, and instead, creates a getterSetterStructure for each JSGlobalObject.
Attachments
proposed patch. (9.14 KB, patch)
2016-04-27 22:50 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-04-27 22:45:10 PDT
<rdar://problem/25965945>
Mark Lam
Comment 2 2016-04-27 22:50:55 PDT
Created attachment 277595 [details] proposed patch.
Mark Lam
Comment 3 2016-04-27 23:55:10 PDT
Thanks for the review. Landed in r200177: <http://trac.webkit.org/r200177>.
Note You need to log in before you can comment on or make changes to this bug.