Bug 157112 - RTL non-native <select> buttons should have arrows on the left
Summary: RTL non-native <select> buttons should have arrows on the left
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-27 18:04 PDT by Dean Jackson
Modified: 2016-04-28 13:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (25.82 KB, patch)
2016-04-27 18:12 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-04-27 18:04:58 PDT 
RTL non-native <select> buttons should have arrows on the left
Comment 1 Dean Jackson 2016-04-27 18:05:52 PDT 
<rdar://problem/25894441>
Comment 2 Dean Jackson 2016-04-27 18:12:55 PDT 
Created attachment 277563 [details]
Patch
Comment 3 Jon Lee 2016-04-27 18:40:24 PDT 
Comment on attachment 277563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:1334
> +        leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom()));

roundf() even with retina?
Comment 4 Dean Jackson 2016-04-27 18:45:42 PDT 
Comment on attachment 277563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:1334
>> +        leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom()));
> 
> roundf() even with retina?

Previously it was just the cast to int, so I guess this might be slightly different on retina.

I'll open a bug to properly retina-fy this whole thing. We should use floats everywhere.
Comment 5 Dean Jackson 2016-04-27 18:59:59 PDT 
Committed r200165: <http://trac.webkit.org/changeset/200165>
Comment 6 Ryan Haddad 2016-04-28 13:33:27 PDT 
Added an ios-simulator expectation for the LayoutTest added with this change in <http://trac.webkit.org/projects/webkit/changeset/200207>