RESOLVED FIXED 157112
RTL non-native <select> buttons should have arrows on the left 
https://bugs.webkit.org/show_bug.cgi?id=157112
Summary RTL non-native <select> buttons should have arrows on the left
Dean Jackson
Reported 2016-04-27 18:04:58 PDT
RTL non-native <select> buttons should have arrows on the left
Attachments
Patch (25.82 KB, patch)
2016-04-27 18:12 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2016-04-27 18:05:52 PDT
<rdar://problem/25894441>
Dean Jackson
Comment 2 2016-04-27 18:12:55 PDT
Created attachment 277563 [details] Patch
Jon Lee
Comment 3 2016-04-27 18:40:24 PDT
Comment on attachment 277563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1334 > + leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom())); roundf() even with retina?
Dean Jackson
Comment 4 2016-04-27 18:45:42 PDT
Comment on attachment 277563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277563&action=review >> Source/WebCore/rendering/RenderThemeMac.mm:1334 >> + leftEdgeOfSeparator = static_cast<int>(roundf(leftEdge - arrowPaddingBefore * renderer.style().effectiveZoom())); > > roundf() even with retina? Previously it was just the cast to int, so I guess this might be slightly different on retina. I'll open a bug to properly retina-fy this whole thing. We should use floats everywhere.
Dean Jackson
Comment 5 2016-04-27 18:59:59 PDT
Committed r200165: <http://trac.webkit.org/changeset/200165>
Ryan Haddad
Comment 6 2016-04-28 13:33:27 PDT
Added an ios-simulator expectation for the LayoutTest added with this change in <http://trac.webkit.org/projects/webkit/changeset/200207>
Note You need to log in before you can comment on or make changes to this bug.