Bug 157107 - [iOS WK2] When determining tile size, check whether ancestor UIScrollViews are actually scrollable
Summary: [iOS WK2] When determining tile size, check whether ancestor UIScrollViews ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-27 16:39 PDT by Simon Fraser (smfr)
Modified: 2016-05-06 18:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.70 KB, patch)
2016-04-27 16:42 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-04-27 16:39:06 PDT 
[iOS WK2] When determining tile size, check whether ancestor UIScrollViews are actually scrollable
Comment 1 Simon Fraser (smfr) 2016-04-27 16:42:43 PDT 
Created attachment 277547 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-04-27 16:43:08 PDT 
rdar://problem/25943577
Comment 3 WebKit Commit Bot 2016-04-27 16:44:21 PDT 
Attachment 277547 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:60:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2016-04-27 16:44:55 PDT 
Comment on attachment 277547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277547&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1956
> ++ (BOOL)scrollViewCanScroll:(UIScrollView *)scrollView

why is this not just a static C function?
Comment 5 Simon Fraser (smfr) 2016-04-27 16:51:41 PDT 
https://trac.webkit.org/r200161
Comment 6 Chris Dumez 2016-05-03 15:19:36 PDT 
Reverted r199259 and r200161 for reason:

Seems to have caused a ~1.2% PLT regression on iOS

Committed r200390: <http://trac.webkit.org/changeset/200390>
Comment 7 Simon Fraser (smfr) 2016-05-06 18:46:48 PDT 
This got re-landed in http://trac.webkit.org/r200470