Bug 157102 - Remove download message receiver when NetworkProcess crashes
Summary: Remove download message receiver when NetworkProcess crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 14:25 PDT by Alex Christensen
Modified: 2016-04-27 14:39 PDT (History)
0 users

See Also:


Attachments
Patch (1.90 KB, patch)
2016-04-27 14:29 PDT, Alex Christensen
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-04-27 14:25:55 PDT
Remove download message receiver when NetworkProcess crashes
Comment 1 Alex Christensen 2016-04-27 14:29:46 PDT
Created attachment 277534 [details]
Patch
Comment 2 Anders Carlsson 2016-04-27 14:34:23 PDT
Comment on attachment 277534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277534&action=review

> Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:75
> +    for (auto it = m_downloads.begin(), end = m_downloads.end(); it != end; ++it) {
> +        it->value->processDidClose();
> +        it->value->invalidate();
> +        m_process->removeMessageReceiver(Messages::DownloadProxy::messageReceiverName(), it->key.downloadID());
>      }

You can get the a download ID from the download itself, no need to iterate both the keys and the values. Also, please use a modern for loop.
Comment 3 Alex Christensen 2016-04-27 14:39:31 PDT
http://trac.webkit.org/changeset/200152