WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157102
Remove download message receiver when NetworkProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=157102
Summary
Remove download message receiver when NetworkProcess crashes
Alex Christensen
Reported
2016-04-27 14:25:55 PDT
Remove download message receiver when NetworkProcess crashes
Attachments
Patch
(1.90 KB, patch)
2016-04-27 14:29 PDT
,
Alex Christensen
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-04-27 14:29:46 PDT
Created
attachment 277534
[details]
Patch
Anders Carlsson
Comment 2
2016-04-27 14:34:23 PDT
Comment on
attachment 277534
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=277534&action=review
> Source/WebKit2/UIProcess/Downloads/DownloadProxyMap.cpp:75 > + for (auto it = m_downloads.begin(), end = m_downloads.end(); it != end; ++it) { > + it->value->processDidClose(); > + it->value->invalidate(); > + m_process->removeMessageReceiver(Messages::DownloadProxy::messageReceiverName(), it->key.downloadID()); > }
You can get the a download ID from the download itself, no need to iterate both the keys and the values. Also, please use a modern for loop.
Alex Christensen
Comment 3
2016-04-27 14:39:31 PDT
http://trac.webkit.org/changeset/200152
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug