Bug 157100 - CSP: Add tests for setting allowContentSecurityPolicySourceStarToMatchAnyProtocol
Summary: CSP: Add tests for setting allowContentSecurityPolicySourceStarToMatchAnyProt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 157005
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-27 13:32 PDT by Daniel Bates
Modified: 2016-04-27 15:49 PDT (History)
2 users (show)

See Also:


Attachments
Layout Tests (24.37 KB, patch)
2016-04-27 13:49 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-04-27 13:32:20 PDT
We should add tests for the setting allowContentSecurityPolicySourceStarToMatchAnyProtocol to ensure that we do not regress its behavior. This setting was added as part of the patch for bug #157005. Although this setting is likely to be short lived it is straightforward to test this setting and should this setting turn out to not be short lived the presence of tests will ensure that we do not regress its behavior.
Comment 1 Daniel Bates 2016-04-27 13:49:38 PDT
Created attachment 277532 [details]
Layout Tests
Comment 2 Brent Fulgham 2016-04-27 14:13:19 PDT
Comment on attachment 277532 [details]
Layout Tests

View in context: https://bugs.webkit.org/attachment.cgi?id=277532&action=review

Looks good! r=me.

> LayoutTests/platform/wk2/TestExpectations:622
> +fast/dom/HTMLImageElement/image-with-blob-url-allowed-by-csp-img-src-star-with-AllowContentSecurityPolicySourceStarToMatchAnyProtocol-enabled.html

Can you please add the usual bugzilla link here for the WKTR lacking drag support?
Comment 3 Daniel Bates 2016-04-27 15:47:49 PDT
(In reply to comment #2)
> [...]
> Can you please add the usual bugzilla link here for the WKTR lacking drag
> support?

Notice that this test is in the list of tests that fail because of a lack of support for eventSender.beginDragWithFiles() in WebKitTestRunner as mentioned in the comment at the start of this list, <http://trac.webkit.org/browser/trunk/LayoutTests/platform/wk2/TestExpectations?rev=199752#L617>.
Comment 4 Daniel Bates 2016-04-27 15:49:33 PDT
Comment on attachment 277532 [details]
Layout Tests

Clearing flags on attachment: 277532

Committed r200155: <http://trac.webkit.org/changeset/200155>
Comment 5 Daniel Bates 2016-04-27 15:49:37 PDT
All reviewed patches have been landed.  Closing bug.