Bug 15710 - When QD plugins draw to an offscreen bitmap and the plugin is not at (0, 0) the clipping rectangle is not correct
Summary: When QD plugins draw to an offscreen bitmap and the plugin is not at (0, 0) t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://gmodules.com/ig/creator?synd=o...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-26 08:54 PDT by Mark Ambachtsheer
Modified: 2007-10-27 03:57 PDT (History)
0 users

See Also:


Attachments
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds. (1.58 KB, patch)
2007-10-26 09:01 PDT, Mark Ambachtsheer
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Ambachtsheer 2007-10-26 08:54:38 PDT
The code to render QD plugins on offscreen GWorlds does not account for the position of the plugin when calculating the clipping rectangle for the QD window.  This is apparent when using a Google Gadget like Bejeweled (URL attached) in an application that uses a WebKit view with an offscreen GWorld (i.e. not Safari).

This was not previously noticed because many widgets/gadgets/Flash videos place the plugin content at (0,0); Google Gadgets on the other hand place a text label above the plugin.
Comment 1 Mark Ambachtsheer 2007-10-26 09:01:21 PDT
Created attachment 16880 [details]
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds.

This is a one-line change that should affect only applications that render to an offscreen GWorld (i.e. not Safari).
Comment 2 Darin Adler 2007-10-26 09:25:25 PDT
Comment on attachment 16880 [details]
Candidate patch for bug 15710; adds the origin to the clipping rect for offscreen GWorlds.

Looks fine, and I'm assuming you tested it in your project.

r=me
Comment 3 Mark Rowe (bdash) 2007-10-27 03:57:37 PDT
Landed in r27148.