Bug 157096 - Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5.
Summary: Address feedback from https://bugs.webkit.org/show_bug.cgi?id=157048#c5.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-27 11:48 PDT by Mark Lam
Modified: 2016-04-27 12:03 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (2.12 KB, patch)
2016-04-27 11:55 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-04-27 11:48:35 PDT 
In JSWrapperMap.mm,
1. Check for USE(APPLE_INTERNAL_SDK) instead of __has_include(<mach-o/dyld_priv.h>).
2. Rename webkitFirstSDKVersionWithInitConstructorSupport to firstSDKVersionWithInitConstructorSupport.
Comment 1 Mark Lam 2016-04-27 11:55:43 PDT 
Created attachment 277523 [details]
proposed patch.
Comment 2 Geoffrey Garen 2016-04-27 11:56:47 PDT 
Comment on attachment 277523 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2016-04-27 12:03:55 PDT 
Thanks for the review.  Landed in r200139: <http://trac.webkit.org/r200139>.