WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
157093
Clean up Font::removeFromSystemFallbackCache()
https://bugs.webkit.org/show_bug.cgi?id=157093
Summary
Clean up Font::removeFromSystemFallbackCache()
Myles C. Maxfield
Reported
2016-04-27 11:01:41 PDT
Clean up Font::removeFromSystemFallbackCache()
Attachments
Patch
(1.90 KB, patch)
2016-04-27 11:04 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2016-04-27 11:04:12 PDT
Created
attachment 277491
[details]
Patch
Darin Adler
Comment 2
2016-04-27 11:35:38 PDT
Comment on
attachment 277491
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=277491&action=review
Looks good.
> Source/WebCore/platform/graphics/Font.cpp:484 > + systemFallbackCache().remove(this);
Should change this function to take a reference, some day.
WebKit Commit Bot
Comment 3
2016-04-27 14:06:38 PDT
Comment on
attachment 277491
[details]
Patch Clearing flags on attachment: 277491 Committed
r200150
: <
http://trac.webkit.org/changeset/200150
>
WebKit Commit Bot
Comment 4
2016-04-27 14:06:42 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5
2016-04-29 16:53:44 PDT
Re-opened since this is blocked by
bug 157216
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug