Bug 157090 - Remove unnecessary HashMap from Font
Summary: Remove unnecessary HashMap from Font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-27 10:44 PDT by Myles C. Maxfield
Modified: 2022-10-10 14:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2016-04-27 10:45 PDT, Myles C. Maxfield
darin: review+
Details | Formatted Diff | Diff
Patch for committing (2.73 KB, patch)
2016-04-27 11:08 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-04-27 10:44:05 PDT
Remove unnecessary HashMap from Font
Comment 1 Myles C. Maxfield 2016-04-27 10:45:41 PDT
Created attachment 277488 [details]
Patch
Comment 2 Darin Adler 2016-04-27 10:57:57 PDT
Comment on attachment 277488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277488&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:40
> +    RetainPtr<CFDictionaryRef>& attributesDictionary = enableKerning ? m_kernedCFStringAttributes : m_nonKernedCFStringAttributes;

I think auto& would be better here.
Comment 3 Myles C. Maxfield 2016-04-27 11:08:08 PDT
Created attachment 277493 [details]
Patch for committing
Comment 4 WebKit Commit Bot 2016-04-27 12:00:09 PDT
Comment on attachment 277493 [details]
Patch for committing

Clearing flags on attachment: 277493

Committed r200140: <http://trac.webkit.org/changeset/200140>
Comment 5 Ahmad Saleem 2022-10-10 14:34:47 PDT
Landed - https://github.com/WebKit/WebKit/commit/dc94eba5215171e6b1a53ee15b619a0d6143cfcd

and didn't back out. Marking this as "RESOLVED FIXED".
Comment 6 Radar WebKit Bug Importer 2022-10-10 14:35:17 PDT
<rdar://problem/100997848>