Moving the core functionality to RenderBlockFlow will allow its use from WK2.
Created attachment 277533 [details] Patch
Attachment 277533 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBlockFlow.h:397: The parameter name "point" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3363: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:3405: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 277533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277533&action=review Please address the style bot issues. > Source/WebCore/rendering/RenderBlockFlow.cpp:3380 > + while (nextChild && nextChild->isFloatingOrOutOfFlowPositioned()) > + nextChild = nextChild->nextSiblingBox(); Why doesn't this do the child->style().visibility() != WebCore::VISIBLE check? > Source/WebCore/rendering/RenderBlockFlow.h:397 > + WEBCORE_EXPORT Node* findClosestTextAtAbsolutePoint(const FloatPoint& point); Being a function on a Renderer, this should return a RenderText, not a Node. The caller can get the node.
Comment on attachment 277533 [details] Patch Attachment 277533 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1230528 New failing tests: compositing/contents-scale/incremental-change.html
Created attachment 277537 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
(In reply to comment #3) > Comment on attachment 277533 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277533&action=review > > Please address the style bot issues. > > > Source/WebCore/rendering/RenderBlockFlow.cpp:3380 > > + while (nextChild && nextChild->isFloatingOrOutOfFlowPositioned()) > > + nextChild = nextChild->nextSiblingBox(); > > Why doesn't this do the child->style().visibility() != WebCore::VISIBLE > check? > Don't know the answer. > > Source/WebCore/rendering/RenderBlockFlow.h:397 > > + WEBCORE_EXPORT Node* findClosestTextAtAbsolutePoint(const FloatPoint& point); > > Being a function on a Renderer, this should return a RenderText, not a Node. > The caller can get the node. Done.
Committed revision 200162.