Bug 157057 - Support legacy HTTP headers in WebSockets
Summary: Support legacy HTTP headers in WebSockets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on: 155602
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-26 18:02 PDT by John Wilander
Modified: 2016-04-28 16:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2016-04-26 18:39 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2016-04-26 18:02:00 PDT 
The following four HTTP headers are needed for legacy reasons:
Sec-WebSocket-Location
Sec-WebSocket-Origin
WebSocket-Location
WebSocket-Origin
Comment 1 John Wilander 2016-04-26 18:03:11 PDT 
rdar://problem/25913345
Comment 2 John Wilander 2016-04-26 18:39:11 PDT 
Created attachment 277432 [details]
Patch
Comment 3 Brent Fulgham 2016-04-26 19:32:47 PDT 
r=me
Comment 4 Alexey Proskuryakov 2016-04-26 19:59:34 PDT 
Comment on attachment 277432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277432&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests since these headers are not officially supported and should not be used.

This is not a reason to avoid tests. If they were worth adding, it's worth verifying that we don't accidentally break them.
Comment 5 WebKit Commit Bot 2016-04-26 20:21:33 PDT 
Comment on attachment 277432 [details]
Patch

Clearing flags on attachment: 277432

Committed r200120: <http://trac.webkit.org/changeset/200120>
Comment 6 WebKit Commit Bot 2016-04-26 20:21:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 John Wilander 2016-04-27 11:51:49 PDT 
Bug for adding test cases: https://bugs.webkit.org/show_bug.cgi?id=157095