Bug 157046 - [JSC] GetByVal on Undecided use its children before its OSR Exit
Summary: [JSC] GetByVal on Undecided use its children before its OSR Exit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 15:26 PDT by Benjamin Poulain
Modified: 2016-04-27 10:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.10 KB, patch)
2016-04-26 15:30 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-04-26 15:26:22 PDT
[JSC] GetByVal on Undecided use its children before its OSR Exit
Comment 1 Benjamin Poulain 2016-04-26 15:30:40 PDT
Created attachment 277413 [details]
Patch
Comment 2 Mark Lam 2016-04-26 15:33:48 PDT
Comment on attachment 277413 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-04-26 16:25:53 PDT
Comment on attachment 277413 [details]
Patch

Clearing flags on attachment: 277413

Committed r200113: <http://trac.webkit.org/changeset/200113>
Comment 4 WebKit Commit Bot 2016-04-26 16:25:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Benjamin Poulain 2016-04-27 10:46:54 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 277413 [details]
> > Patch
> > 
> > Clearing flags on attachment: 277413
> > 
> > Committed r200113: <http://trac.webkit.org/changeset/200113>
> 
> The new test introduced in this change fails on all 32 bit platforms:
> -
> https://build.webkit.org/builders/Apple%20El%20Capitan%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/2205
> -
> https://build.webkit.org/builders/Apple%20Yosemite%2032-
> bit%20JSC%20%28BuildAndTest%29/builds/8925
> -
> https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/60882
> -
> https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/
> builds/390

Oh! Looks like I forgot to fix the 32bit counterpart. I'll do that today.
Comment 7 Benjamin Poulain 2016-04-27 10:58:33 PDT
Quick follow up for 32bit: http://trac.webkit.org/changeset/200133
Thanks Ossy.