Bug 157043 - [Web IDL] Specify default values for optional parameters of type 'unsigned long'
Summary: [Web IDL] Specify default values for optional parameters of type 'unsigned long'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 14:20 PDT by Chris Dumez
Modified: 2016-05-19 12:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2016-04-26 15:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-26 14:20:40 PDT 
Specify default values for optional parameters of type 'unsigned long' and let the bindings generator use WTF::Optional<> for the parameters that do not have such default value.
Comment 1 Chris Dumez 2016-04-26 15:17:55 PDT 
Created attachment 277411 [details]
Patch
Comment 2 Chris Dumez 2016-04-26 15:53:26 PDT 
Comment on attachment 277411 [details]
Patch

Clearing flags on attachment: 277411

Committed r200110: <http://trac.webkit.org/changeset/200110>
Comment 3 Chris Dumez 2016-04-26 15:53:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2016-05-17 10:07:48 PDT 
Interestingly, this was a confirmed 1.5% PLT progression on iOS.
Comment 5 Darin Adler 2016-05-19 12:46:51 PDT 
Which change do you think was responsible?