Bug 157042 - [WinCairo][ANGLE] Display object is not created.
Summary: [WinCairo][ANGLE] Display object is not created.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 13:49 PDT by peavo
Modified: 2016-04-26 14:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2016-04-26 13:53 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-04-26 13:49:29 PDT 
The CreateDisplayFromAttribs function will not create a DisplayD3D object when the requested type is EGL_PLATFORM_ANGLE_TYPE_DEFAULT_ANGLE, because ANGLE_ENABLE_OPENGL is not defined. We should be able to create a DisplayD3D object without defining ANGLE_ENABLE_OPENGL.
Comment 1 peavo 2016-04-26 13:53:48 PDT 
Created attachment 277407 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-26 13:55:04 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 peavo 2016-04-26 13:58:15 PDT 
Thanks for reviewing!
Comment 4 WebKit Commit Bot 2016-04-26 14:46:54 PDT 
Comment on attachment 277407 [details]
Patch

Clearing flags on attachment: 277407

Committed r200107: <http://trac.webkit.org/changeset/200107>
Comment 5 WebKit Commit Bot 2016-04-26 14:46:59 PDT 
All reviewed patches have been landed.  Closing bug.