Bug 157038 - Check to make sure shouldRequestCandidates() before requesting candidates
Summary: Check to make sure shouldRequestCandidates() before requesting candidates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 11:52 PDT by Beth Dakin
Modified: 2016-04-26 13:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.95 KB, patch)
2016-04-26 11:57 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-04-26 11:52:30 PDT 
Check to make sure shouldRequestCandidates() before requesting candidates
Comment 1 Beth Dakin 2016-04-26 11:57:21 PDT 
Created attachment 277403 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-26 11:59:52 PDT 
Attachment 277403 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2172:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1164:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2016-04-26 13:09:26 PDT 
Thanks Tim! http://trac.webkit.org/changeset/200106