Use auto-generated operators in FontPlatformData
Created attachment 277400 [details] Patch
Comment on attachment 277400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277400&action=review > Source/WebCore/platform/graphics/FontPlatformData.h:170 > + FontPlatformData& operator=(const FontPlatformData&) = default; Is this default declaration required, or can it be automatic?
Comment on attachment 277400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277400&action=review >> Source/WebCore/platform/graphics/FontPlatformData.h:170 >> + FontPlatformData& operator=(const FontPlatformData&) = default; > > Is this default declaration required, or can it be automatic? It isn't required, but I still think it's valuable to be explicit in this case.
Comment on attachment 277400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277400&action=review > Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp:89 > + m_scaledFont = adoptRef(cairo_scaled_font_create(fontFace, &fontMatrix, &ctm, options)); Wrong spacing at the beginning. > Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:-49 > -#endif You removed the #endif.
Created attachment 277404 [details] Patch for committing
Comment on attachment 277404 [details] Patch for committing Clearing flags on attachment: 277404 Committed r200104: <http://trac.webkit.org/changeset/200104>
Comment on attachment 277400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277400&action=review >>> Source/WebCore/platform/graphics/FontPlatformData.h:170 >>> + FontPlatformData& operator=(const FontPlatformData&) = default; >> >> Is this default declaration required, or can it be automatic? > > It isn't required, but I still think it's valuable to be explicit in this case. I don’t understand why you say that. Personally I would like to see it removed. > Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:46 > , m_cgFont(0) Initializing this and many other members in the class definition would be beneficial.