Bug 157026 - Update tests in web-platform-tests/html/semantics/scripting-1/
Summary: Update tests in web-platform-tests/html/semantics/scripting-1/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 143519
  Show dependency treegraph
 
Reported: 2016-04-25 23:08 PDT by Ryosuke Niwa
Modified: 2016-04-26 16:02 PDT (History)
2 users (show)

See Also:


Attachments
Reimported tests (98.62 KB, patch)
2016-04-25 23:09 PDT, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-04-25 23:08:07 PDT
Update tests.
Comment 1 Ryosuke Niwa 2016-04-25 23:09:55 PDT
Created attachment 277340 [details]
Reimported tests
Comment 2 Darin Adler 2016-04-26 09:03:01 PDT
Comment on attachment 277340 [details]
Reimported tests

View in context: https://bugs.webkit.org/attachment.cgi?id=277340&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_001.htm:10
> +        <script src="/resources/testharness.js"></script>
> +        <script src="/resources/testharnessreport.js"></script>

Can we make our import script rewrite these so they use paths relative to the test rather than from the top level of the website? That way we can use these tests from file URLs, not just with the test web server running.
Comment 3 Darin Adler 2016-04-26 09:03:20 PDT
Comment on attachment 277340 [details]
Reimported tests

View in context: https://bugs.webkit.org/attachment.cgi?id=277340&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/w3c-import.log:7
>  Then run the Tools/Scripts/import-w3c-tests in Webkit to reimport

Second misspelled WebKit. You fixed one but not the other.
Comment 4 Ryosuke Niwa 2016-04-26 15:53:29 PDT
(In reply to comment #2)
> Comment on attachment 277340 [details]
> Reimported tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277340&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_001.htm:10
> > +        <script src="/resources/testharness.js"></script>
> > +        <script src="/resources/testharnessreport.js"></script>
> 
> Can we make our import script rewrite these so they use paths relative to
> the test rather than from the top level of the website? That way we can use
> these tests from file URLs, not just with the test web server running.

That would be tricky because the script doesn't know where testharness.js is located relative to each test.
Comment 5 Ryosuke Niwa 2016-04-26 16:02:45 PDT
Committed r200111: <http://trac.webkit.org/changeset/200111>