Bug 157018 - Web Inspector: Clarify Heap Snapshot instance Retained Size by hiding retained size of non-dominated children
Summary: Web Inspector: Clarify Heap Snapshot instance Retained Size by hiding retaine...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-25 20:29 PDT by Joseph Pecoraro
Modified: 2016-04-26 08:03 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (9.48 KB, patch)
2016-04-25 20:33 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Before - Show Retained Size for all (220.33 KB, image/png)
2016-04-25 20:33 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] Partial - Show Retained Size for immediately dominated children (209.80 KB, image/png)
2016-04-25 20:34 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After - Show Retained Size for immediately dominated and transitively dominated children (219.52 KB, image/png)
2016-04-25 20:34 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-25 20:29:57 PDT 
* SUMMARY
Clarify Heap Snapshot instance Retained Size by hiding retained size of non-dominated children

It can be confusing to expand a Heap Snapshot Instance and see a larger number than the retained size of the instance itself. That is because this is just a reference to another instance, but it is not dominated by the base object being expanded. Clarify this by only showing retained size of children that are dominated by the base object, and hiding the retained size of children that are not dominated.
Comment 1 Radar WebKit Bug Importer 2016-04-25 20:31:42 PDT 
<rdar://problem/25923913>
Comment 2 Joseph Pecoraro 2016-04-25 20:33:26 PDT 
Created attachment 277314 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-04-25 20:33:56 PDT 
Created attachment 277316 [details]
[IMAGE] Before - Show Retained Size for all
Comment 4 Joseph Pecoraro 2016-04-25 20:34:23 PDT 
Created attachment 277317 [details]
[IMAGE] Partial - Show Retained Size for immediately dominated children
Comment 5 Joseph Pecoraro 2016-04-25 20:34:54 PDT 
Created attachment 277318 [details]
[IMAGE] After - Show Retained Size for immediately dominated and transitively dominated children
Comment 6 WebKit Commit Bot 2016-04-26 08:03:11 PDT 
Comment on attachment 277314 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 277314

Committed r200086: <http://trac.webkit.org/changeset/200086>
Comment 7 WebKit Commit Bot 2016-04-26 08:03:16 PDT 
All reviewed patches have been landed.  Closing bug.