Bug 157017 – [Web IDL] Specify default values for optional parameters of TypedArray types

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Specify default values for optional parameters of TypedArray types and let the bindings generator use WTF::Optional<> for the ones that do not have a default value.

[Chris Dumez]

Created attachment 277320 [details]
Patch

[Darin Adler]

Comment on attachment 277320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277320&action=review

> Source/WebCore/html/HTMLMediaElement.idl:102
> +    [Conditional=ENCRYPTED_MEDIA, RaisesException] void webkitGenerateKeyRequest(DOMString? keySystem, optional Uint8Array initData = null);
> +    [Conditional=ENCRYPTED_MEDIA, RaisesException] void webkitAddKey(DOMString? keySystem, Uint8Array key, optional Uint8Array initData = null, optional DOMString sessionId = null);

This seems a little peculiar. Given that the argument isn’t nullable, I’m not entirely sure that a default of “null” makes logical sense. Anyway, seems a fine practical way to leave the code for now.

[WebKit Commit Bot]

Comment on attachment 277320 [details]
Patch

Clearing flags on attachment: 277320

Committed r200088: <http://trac.webkit.org/changeset/200088>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.