Bug 156995 – [Web IDL] Specify default values for optional parameters of type 'float' / 'unrestricted float'

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Specify default values for optional parameters of type 'float' / 'unrestricted float' and let the bindings generator use WTF::Optional<> for the ones that do not have a default value.

[Chris Dumez]

Created attachment 277283 [details]
Patch

[Darin Adler]

Comment on attachment 277283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277283&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1267
> +    setShadow(FloatSize(width, height), blur, alpha ? colorWithOverrideAlpha(rgba, alpha.value()) : rgba);

Seems like we it would be elegant to add an overload of colorWithOverrideAlpha that takes an Optional. It can be inlined, but it would be nice to have it there, rather than writing it out here.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:131
> +    void setStrokeColor(unrestricted float grayLevel, optional float alpha = 1.0);

I think just "= 1" would be nicer.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:136
> +    void setFillColor(unrestricted float grayLevel, optional unrestricted float alpha = 1.0);

Ditto.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:166
> +        optional unrestricted float alpha = 1.0);

Ditto.

[Chris Dumez]

Created attachment 277293 [details]
Patch

[Chris Dumez]

Comment on attachment 277293 [details]
Patch

Clearing flags on attachment: 277293

Committed r200058: <http://trac.webkit.org/changeset/200058>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.