Bug 156987 - AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391
Summary: AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2016-04-25 12:13 PDT by Nan Wang
Modified: 2016-04-25 15:40 PDT (History)
11 users (show)

See Also:

Initial patch (4.34 KB, patch)
2016-04-25 12:21 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (4.08 KB, patch)
2016-04-25 13:55 PDT, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-04-25 12:13:30 PDT
Crash when asking for the slider indicator's value if the parent slider is null.

Comment 1 Nan Wang 2016-04-25 12:21:34 PDT
Created attachment 277266 [details]
Initial patch
Comment 2 chris fleizach 2016-04-25 13:43:50 PDT
Comment on attachment 277266 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277266&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2751
> +            return !m_object->parentObject() ? nullptr : [NSNumber numberWithFloat:m_object->parentObject()->valueForRange()];

can we instead check earlier than this if the object is detachedFromParent() 
then that will take care of this and other cases
Comment 3 Nan Wang 2016-04-25 13:55:40 PDT
Created attachment 277276 [details]

review comments.
Comment 4 WebKit Commit Bot 2016-04-25 15:40:19 PDT
Comment on attachment 277276 [details]

Clearing flags on attachment: 277276

Committed r200054: <http://trac.webkit.org/changeset/200054>
Comment 5 WebKit Commit Bot 2016-04-25 15:40:25 PDT
All reviewed patches have been landed.  Closing bug.