Bug 156980 - Remove the REQUEST_ANIMATION_FRAME flag
Summary: Remove the REQUEST_ANIMATION_FRAME flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-25 08:29 PDT by Antoine Quint
Modified: 2017-01-16 22:22 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (81.39 KB, patch)
2017-01-16 20:44 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-04-25 08:29:03 PDT 
I don't know if it is safe to do so, but I would be surprised if there are any ports with REQUEST_ANIMATION_FRAME off. We should consider removing this flag.
Comment 1 Radar WebKit Bug Importer 2016-04-25 08:29:48 PDT 
<rdar://problem/25906849>
Comment 2 Joseph Pecoraro 2017-01-16 20:21:24 PST 
Lets do it. I can bump the thread and put a patch here.
Comment 3 Joseph Pecoraro 2017-01-16 20:44:49 PST 
Created attachment 299014 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2017-01-16 21:38:20 PST 
Comment on attachment 299014 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299014&action=review

> Source/WebCore/page/DOMWindow.idl:166
> +    [ImplementedAs=cancelAnimationFrame] void webkitCancelAnimationFrame(long id);
> +    [ImplementedAs=cancelAnimationFrame] void webkitCancelRequestAnimationFrame(long id); // This is a deprecated alias for webkitCancelAnimationFrame(). Remove this when removing vendor prefix.

It may be time to look into removing these.

> Tools/Scripts/webkitperl/FeatureList.pm:-79
> -    $detailsElementSupport,
>      $deviceOrientationSupport,
> -    $directoryUploadSupport,
>      $dom4EventsConstructor,
> -    $domIterator,

Many of these features were removed a long time ago and their variables forgotten.
Comment 5 WebKit Commit Bot 2017-01-16 22:22:07 PST 
Comment on attachment 299014 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299014

Committed r210797: <http://trac.webkit.org/changeset/210797>
Comment 6 WebKit Commit Bot 2017-01-16 22:22:11 PST 
All reviewed patches have been landed.  Closing bug.