Bug 156980 – Remove the REQUEST_ANIMATION_FRAME flag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Antoine Quint]

I don't know if it is safe to do so, but I would be surprised if there are any ports with REQUEST_ANIMATION_FRAME off. We should consider removing this flag.

[Radar WebKit Bug Importer]

<rdar://problem/25906849>

[Joseph Pecoraro]

Lets do it. I can bump the thread and put a patch here.

[Joseph Pecoraro]

Created attachment 299014 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299014 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299014&action=review

> Source/WebCore/page/DOMWindow.idl:166
> +    [ImplementedAs=cancelAnimationFrame] void webkitCancelAnimationFrame(long id);
> +    [ImplementedAs=cancelAnimationFrame] void webkitCancelRequestAnimationFrame(long id); // This is a deprecated alias for webkitCancelAnimationFrame(). Remove this when removing vendor prefix.

It may be time to look into removing these.

> Tools/Scripts/webkitperl/FeatureList.pm:-79
> -    $detailsElementSupport,
>      $deviceOrientationSupport,
> -    $directoryUploadSupport,
>      $dom4EventsConstructor,
> -    $domIterator,

Many of these features were removed a long time ago and their variables forgotten.

[WebKit Commit Bot]

Comment on attachment 299014 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299014

Committed r210797: <http://trac.webkit.org/changeset/210797>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.