Bug 156979 - Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Summary: Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 156844
  Show dependency tree / graph
 
Reported: 2016-04-25 08:04 PDT by youenn fablet
Modified: 2016-04-26 06:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2016-04-25 08:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.53 KB, patch)
2016-04-26 05:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-04-25 08:04:18 PDT 
Drop [UsePointersEvenForNonNullableObjectArguments] from WebKitNamedFlow
Comment 1 youenn fablet 2016-04-25 08:07:31 PDT 
Created attachment 277249 [details]
Patch
Comment 2 Chris Dumez 2016-04-25 10:44:10 PDT 
Comment on attachment 277249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277249&action=review

r=me with comment.

> Source/WebCore/dom/WebKitNamedFlow.idl:38
> +    NodeList getRegionsByContent(Node? contentNode);

Should add a FIXME comment as I don't believe this matches the spec.
Comment 3 youenn fablet 2016-04-26 05:15:00 PDT 
Created attachment 277357 [details]
Patch for landing
Comment 4 youenn fablet 2016-04-26 05:16:25 PDT 
Thanks for the review.

> > Source/WebCore/dom/WebKitNamedFlow.idl:38
> > +    NodeList getRegionsByContent(Node? contentNode);
> 
> Should add a FIXME comment as I don't believe this matches the spec.

Right, I did not find the spec yesterday but found it now.
Patch is fixed accordingly
Comment 5 WebKit Commit Bot 2016-04-26 06:17:00 PDT 
Comment on attachment 277357 [details]
Patch for landing

Clearing flags on attachment: 277357

Committed r200079: <http://trac.webkit.org/changeset/200079>
Comment 6 WebKit Commit Bot 2016-04-26 06:17:04 PDT 
All reviewed patches have been landed.  Closing bug.