Bug 156967 - [Web IDL] Specify default values for parameters of type 'unsigned short'
Summary: [Web IDL] Specify default values for parameters of type 'unsigned short'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-24 19:38 PDT by Chris Dumez
Modified: 2016-04-25 11:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.46 KB, patch)
2016-04-24 19:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.14 KB, patch)
2016-04-25 10:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-24 19:38:07 PDT 
Specify default values for parameters of type 'unsigned short'
Comment 1 Chris Dumez 2016-04-24 19:41:51 PDT 
Created attachment 277212 [details]
Patch
Comment 2 Darin Adler 2016-04-24 22:13:05 PDT 
Comment on attachment 277212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277212&action=review

> Source/WebCore/testing/Internals.idl:229
> +    [RaisesException] DOMString layerTreeAsText(Document document, optional unsigned short flags = 0);

I don’t understand why the IDL says "unsigned short", but the implementation says "unsigned". These should be "unsigned long" instead.

> Source/WebCore/testing/Internals.idl:244
> +    [RaisesException] DOMString displayListForElement(Element element, optional unsigned short flags = 0);

Ditto.

> Source/WebCore/testing/Internals.idl:246
> +    [RaisesException] DOMString replayDisplayListForElement(Element element, optional unsigned short flags = 0);

Ditto.
Comment 3 Chris Dumez 2016-04-25 10:49:26 PDT 
Created attachment 277260 [details]
Patch
Comment 4 Chris Dumez 2016-04-25 11:38:30 PDT 
Comment on attachment 277260 [details]
Patch

Clearing flags on attachment: 277260

Committed r200037: <http://trac.webkit.org/changeset/200037>
Comment 5 Chris Dumez 2016-04-25 11:38:36 PDT 
All reviewed patches have been landed.  Closing bug.