Bug 156965 – Web Inspector: Can't sort by name/source code location columns in Timeline data grids

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Can't sort by name/source code location columns in Timeline data grids. In the network and script (details) data grids, these columns contain document fragments and can't be sorted.

For "location" to work, TimelineDataGrid's sort comparer just needs a special case for SourceCodeLocation values. For the name column which can contain main title and subtitle text, add a delegate to TimelineDataGrid so that view's can override the sort comparer per-column, as needed.

[Radar WebKit Bug Importer]

<rdar://problem/25898716>

[Matt Baker]

Created attachment 277207 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 277207 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277207&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js:-304
> -        let currentDataGridNode = this.children[0];

The children array here was not the DOM, it is DataGridNodes. You should revert this.

[Matt Baker]

Created attachment 277211 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 277211 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277211

Committed r199974: <http://trac.webkit.org/changeset/199974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.