Bug 156965 - Web Inspector: Can't sort by name/source code location columns in Timeline data grids
Summary: Web Inspector: Can't sort by name/source code location columns in Timeline da...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-24 17:54 PDT by Matt Baker
Modified: 2016-04-24 20:08 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (11.81 KB, patch)
2016-04-24 18:05 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (11.12 KB, patch)
2016-04-24 19:01 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-04-24 17:54:35 PDT 
* SUMMARY
Can't sort by name/source code location columns in Timeline data grids. In the network and script (details) data grids, these columns contain document fragments and can't be sorted.

For "location" to work, TimelineDataGrid's sort comparer just needs a special case for SourceCodeLocation values. For the name column which can contain main title and subtitle text, add a delegate to TimelineDataGrid so that view's can override the sort comparer per-column, as needed.
Comment 1 Radar WebKit Bug Importer 2016-04-24 17:54:57 PDT 
<rdar://problem/25898716>
Comment 2 Matt Baker 2016-04-24 18:05:08 PDT 
Created attachment 277207 [details]
[Patch] Proposed Fix
Comment 3 Timothy Hatcher 2016-04-24 18:39:25 PDT 
Comment on attachment 277207 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277207&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js:-304
> -        let currentDataGridNode = this.children[0];

The children array here was not the DOM, it is DataGridNodes. You should revert this.
Comment 4 Matt Baker 2016-04-24 19:01:45 PDT 
Created attachment 277211 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-04-24 20:08:55 PDT 
Comment on attachment 277211 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277211

Committed r199974: <http://trac.webkit.org/changeset/199974>
Comment 6 WebKit Commit Bot 2016-04-24 20:08:59 PDT 
All reviewed patches have been landed.  Closing bug.