Bug 156960 - Web Inspector: Error when selecting a bar in the Frames timeline
Summary: Web Inspector: Error when selecting a bar in the Frames timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 154924
Blocks: 156963
  Show dependency tree / graph
 
Reported: 2016-04-24 14:41 PDT by Matt Baker
Modified: 2016-04-24 18:03 PDT (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (5.74 KB, patch)
2016-04-24 16:04 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-04-24 14:41:40 PDT 
* SUMMARY
Error when selecting a bar in the Frames timeline. Inspector dies with: undefined is not an object (evaluating 'this.currentTimelineView.navigationSidebarTreeOutline.selectedTreeElement').

* NOTE
The fault lies with TimelineRecordingContentView._recordSelected, which assumes all TimelineViews have a tree outline.
Comment 1 Radar WebKit Bug Importer 2016-04-24 14:41:54 PDT 
<rdar://problem/25897955>
Comment 2 Matt Baker 2016-04-24 14:43:43 PDT 
A fix is ready. Waiting on https://webkit.org/b/154924, which adds grid support to TimelineView.
Comment 3 Matt Baker 2016-04-24 16:04:05 PDT 
Created attachment 277200 [details]
[Patch] Proposed Fix
Comment 4 Matt Baker 2016-04-24 16:10:00 PDT 
This patch prevents the crash but there is another problem with record selection: https://bugs.webkit.org/show_bug.cgi?id=156963
Comment 5 WebKit Commit Bot 2016-04-24 18:02:58 PDT 
Comment on attachment 277200 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277200

Committed r199972: <http://trac.webkit.org/changeset/199972>
Comment 6 WebKit Commit Bot 2016-04-24 18:03:02 PDT 
All reviewed patches have been landed.  Closing bug.