Bug 156954 - [Win] The function findTopLevelParent should return the first window which is not a child.
Summary: [Win] The function findTopLevelParent should return the first window which is...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-23 09:30 PDT by peavo
Modified: 2023-10-27 18:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2016-04-23 09:35 PDT, peavo 		beidson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-04-23 09:30:19 PDT 
The function findTopLevelParent is used when the active state of the browser is determined. It usually works very well, but when there is a window with the style WS_POPUP in the hierarchy which has a parent, the function will not return this window, but keep walking the hierarchy. A window with the WS_POPUP style cannot have the WS_CHILD style, and is a type of top level window, even though it can have a parent/owner.
Comment 1 peavo 2016-04-23 09:35:03 PDT 
Created attachment 277151 [details]
Patch
Comment 2 Darin Adler 2016-04-24 09:47:56 PDT 
Comment on attachment 277151 [details]
Patch

How did you test this change?
Comment 3 Brady Eidson 2017-08-19 16:01:28 PDT 
Comment on attachment 277151 [details]
Patch

r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.