WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
156954
[Win] The function findTopLevelParent should return the first window which is not a child.
https://bugs.webkit.org/show_bug.cgi?id=156954
Summary
[Win] The function findTopLevelParent should return the first window which is...
peavo
Reported
2016-04-23 09:30:19 PDT
The function findTopLevelParent is used when the active state of the browser is determined. It usually works very well, but when there is a window with the style WS_POPUP in the hierarchy which has a parent, the function will not return this window, but keep walking the hierarchy. A window with the WS_POPUP style cannot have the WS_CHILD style, and is a type of top level window, even though it can have a parent/owner.
Attachments
Patch
(1.68 KB, patch)
2016-04-23 09:35 PDT
,
peavo
beidson
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
peavo
Comment 1
2016-04-23 09:35:03 PDT
Created
attachment 277151
[details]
Patch
Darin Adler
Comment 2
2016-04-24 09:47:56 PDT
Comment on
attachment 277151
[details]
Patch How did you test this change?
Brady Eidson
Comment 3
2017-08-19 16:01:28 PDT
Comment on
attachment 277151
[details]
Patch r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Ahmad Saleem
Comment 4
2023-10-27 18:13:56 PDT
This seems to be not applied:
https://github.com/WebKit/WebKit/blob/02f9dd1869da489a1d8ccc25e7e9b8a86aadef58/Source/WebKit/UIProcess/win/WebView.cpp#L302
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug