Bug 156951 - [Win] Plugin stream temporary file is deleted too early.
Summary: [Win] Plugin stream temporary file is deleted too early.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-23 03:03 PDT by peavo
Modified: 2022-07-01 10:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2016-04-23 03:28 PDT, peavo 		beidson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-04-23 03:03:16 PDT 
The plugin stream temporary file is currently deleted in PluginStream::destroyStream(). This is too early for some plugins, since they appear to be trying to read this file after m_pluginFuncs->asfile() has been called. The file will then be deleted, and the plugin will fail to read it. We can instead delete the temporary file in the plugin stream destructor.
Comment 1 peavo 2016-04-23 03:28:16 PDT 
Created attachment 277146 [details]
Patch
Comment 2 Darin Adler 2016-04-23 16:43:36 PDT 
Comment on attachment 277146 [details]
Patch

It’s normally not a good pattern to do any externally visible work that is based on reference counting. It’s very easy to accidentally change the timing. We have worked hard to not do this kind of work in the destructors in most cases. Is there some other time that’s appropriate other than destruction of the stream object?
Comment 3 Brady Eidson 2017-08-19 16:01:20 PDT 
Comment on attachment 277146 [details]
Patch

r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Comment 4 Brent Fulgham 2022-07-01 10:38:36 PDT 
NPAPI plugins have been removed.